This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(select): don't call $render twice if $viewValue ref changes #11412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credits to @tepez for the fix Closes angular#11329
| @@ -200,11 +200,13 @@ var selectDirective = function() { | |||
|
|
|||
| // we have to do it on each watch since ngModel watches reference, but | |||
| // we need to work of an array, so we need to see if anything was inserted/removed | |||
| var lastView, lastViewRef = NaN; | |||
There was a problem hiding this comment.
lastView is already declared up top isn't it?
There was a problem hiding this comment.
True - now that I see it, isn't it a bit weird that it is defined outside the link fn? So every selectDirective uses the same variable?
There was a problem hiding this comment.
I agree so I moved it inside.
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Credits to @tepez for the fix Closes angular#11329 Closes angular#11412
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits to @tepez for the fix
Closes #11329