This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngOptions): correctly watch displayed value for changes #11765
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngOptions does not update the displayed value properly if the property being used as the label changes when not using the "select as" or "track by" syntax, i.e
<select ng-options="value.label for value in array"></select>
will not update ifarray[0].label
is changed but<select ng-options="value.label as value.label for value in array></select>
will correctly update.The bug is demonstrated here: https://jsfiddle.net/76qrsctv/17/
The proposed change fixes this issue.