This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAria): update aria-valuemin/max when min/max change
#11774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
force-pushed
the
ngAria-observe-value-attributes
branch
from
0ee9e85 to
e880f4d
Compare
This was referenced Apr 30, 2015
| expect(element.attr('aria-valuemax')).toBe('100'); | ||
| }); | ||
|
|
||
| it('should update `aria-valuemin/max` when using `ng-min/max`', function() { |
There was a problem hiding this comment.
This should be worded similar to the test above. Or both wrapped in a describe.
As a result of thi fix, `ngMin/Max` also set `aria-valuemin/max` on "range"-shaped elements. Fixes angular#11770
gkalpak
force-pushed
the
ngAria-observe-value-attributes
branch
from
e880f4d to
449ef08
Compare
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
As a result of thi fix, `ngMin/Max` also set `aria-valuemin/max` on "range"-shaped elements. Fixes angular#11770 Closes angular#11774
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of thi fix,
ngMin/Maxalso setaria-valuemin/maxon"range"-shaped elements.
Fixes #11770