This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngOptions): ensure that tracked properties are always watched #11784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 47f9fc3 failed to account for changes to the tracked value of model items in a collection where the select was `multiple`. See angular#11743 (comment)
| scope.$watch( | ||
| function() { return ngOptions.getTrackByValue(ngModelCtrl.$viewValue); }, | ||
| function() { ngModelCtrl.$render(); } | ||
| ); |
There was a problem hiding this comment.
So now, when the select is not multiple, there is only a simple watch on the tracked value.
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Commit 47f9fc3 failed to account for changes to the tracked value of model items in a collection where the select was `multiple`. See angular#11743 (comment) Closes angular#11784
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 47f9fc3 failed to account for changes to
the tracked value of model items in a collection where the select was
multiple.See #11743 (comment)