This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Enforce a best practice on the ng-animate CSS class
#11807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meFilter Since ngAnimate uses the `ng-animate` CSS class internally to track state it is better to keep this as a reserved CSS class to avoid accidentally adding / removing the CSS class when an animation is started and closed. BREAKING CHANGE: partially or fully using a regex value containing `ng-animate` as a token is not allowed anymore. Doing so will trigger a minErr exception to be thrown. So don't do this: ```js // only animate elements that contain the `ng-animate` CSS class $animateProvider.classNameFilter(/ng-animate/); // or partially contain it $animateProvider.classNameFilter(/some-class ng-animate another-class/); // but this is OK $animateProvider.classNameFilter(/ng-animate-special/); ``` Closes angular#11431
matsko
force-pushed
the
ng_animate_class_name
branch
from
3cd3000 to
1e1f49c
Compare
|
👍 |
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
…meFilter Since ngAnimate uses the `ng-animate` CSS class internally to track state it is better to keep this as a reserved CSS class to avoid accidentally adding / removing the CSS class when an animation is started and closed. BREAKING CHANGE: partially or fully using a regex value containing `ng-animate` as a token is not allowed anymore. Doing so will trigger a minErr exception to be thrown. So don't do this: ```js // only animate elements that contain the `ng-animate` CSS class $animateProvider.classNameFilter(/ng-animate/); // or partially contain it $animateProvider.classNameFilter(/some-class ng-animate another-class/); ``` but this is OK: ```js $animateProvider.classNameFilter(/ng-animate-special/); ``` Closes angular#11431 Closes angular#11807
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ngAnimate uses the
ng-animateCSS class internally to trackstate it is better to keep this as a reserved CSS class to avoid
accidentally adding / removing the CSS class when an animation is
started and closed.
BREAKING CHANGE: partially or fully using a regex value containing
ng-animateas a token is not allowed anymore. Doing so will trigger aminErr exception to be thrown.
So don't do this:
Closes #11431