This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngClass): add/remove classes which are properties of Object.prototype #11814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind rewriting the commit message to clearly explain what the problem is/was and what the patch is fixing? There's a lot of domain-specific stuff in here that is hard to understand. |
|
@matsko PTAL, I've made the commit message more thorough and refactored it a bit. |
| for (key in obj) { | ||
| iterator.call(context, obj[key], key, obj); | ||
| } | ||
| } else if (typeof obj.hasOwnProperty === 'function') { |
There was a problem hiding this comment.
We probably don't care, but shadowing hasOwnProperty with a function will not be handled correctly.
Just saying...
There was a problem hiding this comment.
Depends on how it's shadowed --- I don't think we care, common case is a custom hasOwnProperty method won't be used
|
huh --- I guess this patch discovered a new IE quirk :< ( |
caitp
force-pushed
the
issue-11813
branch
3 times, most recently
from
70da3aa to
40356e7
Compare
…type Previously, ngClass and ngAnimate would track the status of classes using an ordinary object. This causes problems when class names match names of properties in Object.prototype, including non-standard Object.prototype properties such as 'watch' and 'unwatch' in Firefox. Because of this shadowing, ngClass and ngAnimate were unable to correctly determine the changed status of these classes. In orderto accomodate this patch, some changes have been necessary elsewhere in the codebase, in order to facilitate iterating, comparingand copying objects with a null prototype, or which shadow the `hasOwnProperty` method Summary: - fast paths for various internal functions when createMap() is used - Make createMap() safe for internal functions like copy/equals/forEach - Use createMap() in more places to avoid needing hasOwnProperty() Closes angular#11813
|
ping |
|
pong |
|
LGTM. Excellent work. |
|
thanks |
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
…type Previously, ngClass and ngAnimate would track the status of classes using an ordinary object. This causes problems when class names match names of properties in Object.prototype, including non-standard Object.prototype properties such as 'watch' and 'unwatch' in Firefox. Because of this shadowing, ngClass and ngAnimate were unable to correctly determine the changed status of these classes. In orderto accomodate this patch, some changes have been necessary elsewhere in the codebase, in order to facilitate iterating, comparingand copying objects with a null prototype, or which shadow the `hasOwnProperty` method Summary: - fast paths for various internal functions when createMap() is used - Make createMap() safe for internal functions like copy/equals/forEach - Use createMap() in more places to avoid needing hasOwnProperty() R=@matsko Closes angular#11813 Closes angular#11814
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11813