fix($location): Infinite digest in $location replace in IE9 #11935
Conversation
|
Well, this is certainly a much more concise version of what I was directly fixing. I'm going to update my patch in the other pull request with something I was knocking around this morning that I'd like you to ponder. I believe the problem is somewhat more widespread than previously thought (impacting more cases) because the mock browser didn't expose the bug. |
|
Perhaps we do need to update ngMock browser across the board as you say? |
|
Seems at the least like it would be a more honest accounting of what's really going wrong in the app, which should lead to more bullet-proof fixes. :) |
|
Is there an easy way to run the karma tests on another browser locally? (I'm relatively new to grunt.) |
|
Easiest way to run tests locally is to use |
|
Thanks! Please see new version over on #11675. |
|
So is this fixed, or...? |
|
Moving focus to #11675. I will try to land this in the next couple of days :-) |
|
Gotcha. Thanks again for all your help! —Reply to this email directly or view it on GitHub. |
| $rootScope.$on('$locationChangeSuccess', function() { | ||
| if ($location.path() !== '/') { | ||
| $location.path('/').replace(); | ||
| } |
Thanks to @hamfastgamgee for getting this fix in place. Closes #11439 Closes #11675 Closes #11935 Closes #12083
Thanks to @hamfastgamgee for getting this fix in place. Closes #11439 Closes #11675 Closes #11935 Closes #12083
Thanks to @hamfastgamgee for getting this fix in place. Closes angular#11439 Closes angular#11675 Closes angular#11935 Closes angular#12083
@hamfastgamgee - I think this is the right unit test. Can you take a look. The nice thing is that it even fails on Chrome as well (since we are simulating no-history support) without the fix.