This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngAria): add option to disable role=button #12234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| compileElement('<radio-group ng-click="something"></radio-group>'); | ||
| expect(element.attr('role')).toBeUndefined(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
It matches the rest of the file. I didn't want to introduce whitespace changes, especially to make the whole file consistent. But if it's important, I can....
There was a problem hiding this comment.
Inside the function you are using 4 spaces (most of the time). It should be 2 spaces (according to Angular's "styleguide".
(I don't think it's a big deal, but I have a thing about whitespace inconsistency :P)
|
LGTM (other than the whitespace nitpick) as long as Travis is happy. |
marcysutton
force-pushed
the
ngaria-clickrole
branch
from
573c0c1 to
521bf23
Compare
|
@gkalpak I fixed the whitespace, looks like Travis stopped complaining about whatever it was failing on. It looked very unrelated to these changes when I dug into them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am separating a larger ngAria refactor into smaller pieces and getting them submitted! Starting with a config option for
role="button", which is added by ngClick onto divs or custom elements like<radio-group>. IfbindRoleForClickis set to false in the config, ngAria will not add the button role to custom elements usingng-click. I'm totally open to renaming the config variable.Closes #11580
Note config options are app-wide–an awesome improvement would be to scope them by controllers or directives. Related to #11174.