This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($parse): assign returns the new value
#12708
Closed
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalfaso
force-pushed
the
assign-return
branch
from
77a637e to
109cf50
Compare
| @@ -2793,7 +2793,7 @@ describe('parser', function() { | |||
| var fn = $parse('a'); | |||
| expect(fn.assign).toBeTruthy(); | |||
| var scope = {}; | |||
| fn.assign(scope, 123); | |||
| expect(fn.assign(scope, 123)).toBe(123); | |||
There was a problem hiding this comment.
If we are super nitpicky, this is out of scope for this test (i.e. it should be its own it). But it's no dealbreaker
|
LGTM, expect for that nitpick |
The `.assign` function returns the new value. The version with csp enabled already has this behavior. Closes angular#12675
lgalfaso
force-pushed
the
assign-return
branch
from
109cf50 to
2e6bbae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.assignfunction returns the new value.The version with csp enabled already has this behavior.
Closes #12675