Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($resource): prevent URL template from collapsing into an empty string #5493

Closed
wants to merge 1 commit into from

Conversation

gsklee
Copy link
Contributor

@gsklee gsklee commented Dec 20, 2013

Closes #5455

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@gsklee
Copy link
Contributor Author

gsklee commented Dec 20, 2013

Signed as Gias Kay Lee, email's the same with my GitHub account.

@ghost ghost assigned matsko Dec 20, 2013
@IgorMinar
Copy link
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@IgorMinar IgorMinar closed this in 131e401 Jan 3, 2014
@IgorMinar
Copy link
Contributor

merged. thanks!

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
…ring

if url template would result in an empty string, we should make a request
to '/' instead.

Closes angular#5455
Closes angular#5493
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
…ring

if url template would result in an empty string, we should make a request
to '/' instead.

Closes angular#5455
Closes angular#5493
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$resource shouldn't collapse URL to ""
3 participants