This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): retain CSS classes added in clone fn on async directive #5617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops. |
| // it was cloned therefore we have to clone as well. | ||
| linkNode = jqLiteClone(compileNode); | ||
| replaceWith(linkRootElement, jqLite(beforeTemplateLinkNode), linkNode); | ||
|
|
||
| // Copy in CSS classes from original node | ||
| safeAddClass(jqLite(linkNode), oldClasses); |
There was a problem hiding this comment.
I'd like to make a change to safeAddClass so that I can make sure it works correctly for SVG elements and SVGAnimatedString class names.
That can wait for a different PR, though.
ghost
assigned 
|
@matsko can you please review? |
|
Hey guys. Sorry for the delay. I am happy to review tomorrow night and/or Thursday. |
|
the test is quite hard to follow any chance it could be simplified. if not then this lgtm |
|
I'll see if I can simplify the test a bit |
In synchronous directives (without a templateUrl), classes added to the node during the clone attach function persist in the post-link function. Before this patch, classes addedd to asynchronous templates during the clone attach function would not persist after the node is replaced with the template prior to linking. Fixes angular#5439
|
Comments addressed, I'm going to merge this when travis is green |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In synchronous directives (without a templateUrl), classes added to the node during the clone attach function persist in the post-link function.
Before this patch, classes addedd to asynchronous templates during the clone attach function would not persist after the node is replaced with the template prior to linking.
Fixes #5439