fix($location): return '/' for root path in hashbang mode #5712

caitp · 2014-01-09T19:21:10Z

Before this change, on the root of the application, $location.path() would return the empty string. Following this change, it will always return a root of '/'.

Closes #5650

Before this change, on the root of the application, $location.path() would return the empty string. Following this change, it will always return a root of '/'. Closes angular#5650

This reverts commit 63cd873. The change breaks existing tests of Google apps. The problem is that while we tried to avoid adding #/ to window.location.href unnecessarily we failed doing so. Likely because by setting $path, at some point (during a digest) we try to check if $location changed and we mistake the default '/' with an explicit settign of the path via the `path()` method. This results in us writing the url with '#/' into $browser.url() which updates the window.location by adding "#/" to the url - something we tried to avoid in the first place. I'll reopen PR #5712.

IgorMinar · 2014-01-10T07:51:48Z

I hacked up an incomplete fix for the issue due to which the commit got reverted:

diff --git a/src/ng/location.js b/src/ng/location.js
index 0a47445..b8ce427 100644
--- a/src/ng/location.js
+++ b/src/ng/location.js
@@ -609,6 +609,7 @@ function $LocationProvider(){
       LocationMode = $sniffer.history ? LocationHtml5Url : LocationHashbangInHtml5Url;
     } else {
       appBase = stripHash(initialUrl);
+      initialUrl = (initialUrl.indexOf('#') === -1) ? initialUrl + '#/' : initialUrl;
       LocationMode = LocationHashbangUrl;
     }
     $location = new LocationMode(appBase, '#' + hashPrefix);
@@ -679,6 +680,7 @@ function $LocationProvider(){
     var changeCounter = 0;
     $rootScope.$watch(function $locationWatch() {
       var oldUrl = $browser.url();
+      if (oldUrl.indexOf('#') === -1) oldUrl = oldUrl + '#/';
       var currentReplace = $location.$$replace;

       if (!changeCounter || oldUrl != $location.absUrl()) {

it seems that we'll need to change all tests in Angular that expect $location.path() to return an empty string, once we fix this properly this should never be possible. $location.path() should always something that matches /\/.*/.

I consider this to be a breaking change, so we should reschedule this fix for 1.3

caitp · 2014-01-10T22:31:43Z

Ah, understood

gsklee · 2014-01-11T09:21:39Z

Just a headsup, I'm seeing this being listed inside the 1.2.8 change log.

caitp · 2014-01-11T16:27:01Z

Yes, unfortunately the reversion doesn't remove it from the changelog, and doesn't get listed itself. hmm

Before this change, on the root of the application, $location.path() would return the empty string. Following this change, it will always return a root of '/'. Closes angular#5650 Closes angular#5712

This reverts commit 63cd873. The change breaks existing tests of Google apps. The problem is that while we tried to avoid adding #/ to window.location.href unnecessarily we failed doing so. Likely because by setting $path, at some point (during a digest) we try to check if $location changed and we mistake the default '/' with an explicit settign of the path via the `path()` method. This results in us writing the url with '#/' into $browser.url() which updates the window.location by adding "#/" to the url - something we tried to avoid in the first place. I'll reopen PR angular#5712.

Before this change, on the root of the application, $location.path() would return the empty string. Following this change, it will always return a root of '/'. Closes angular#5650 Closes angular#5712

This reverts commit 63cd873. The change breaks existing tests of Google apps. The problem is that while we tried to avoid adding #/ to window.location.href unnecessarily we failed doing so. Likely because by setting $path, at some point (during a digest) we try to check if $location changed and we mistake the default '/' with an explicit settign of the path via the `path()` method. This results in us writing the url with '#/' into $browser.url() which updates the window.location by adding "#/" to the url - something we tried to avoid in the first place. I'll reopen PR angular#5712.

caitp · 2014-02-21T23:29:52Z

Just as a note, #5977 has a tiny bit of code in it which will need to be altered here due to the breaking change.

fix($location): return '/' for root path in hashbang mode

09bf754

Before this change, on the root of the application, $location.path() would return the empty string. Following this change, it will always return a root of '/'. Closes angular#5650

ghost assigned IgorMinar Jan 10, 2014

IgorMinar closed this in 63cd873 Jan 10, 2014

IgorMinar reopened this Jan 10, 2014

caitp force-pushed the master branch from 591bac5 to d713ad1 Compare August 22, 2014 13:50

tbosch force-pushed the master branch from 6c27b89 to 271572c Compare August 30, 2014 00:57

tbosch force-pushed the master branch from a3d7934 to 1418383 Compare September 10, 2014 18:14

petebacondarwin force-pushed the master branch from 02dc2aa to fd2d6c0 Compare September 16, 2014 11:25

jeffbcross force-pushed the master branch from dbbabb9 to 27d1234 Compare September 27, 2014 00:05

btford modified the milestones: 1.3.0, 1.3.0-rc.5 Sep 30, 2014

jeffbcross force-pushed the master branch from cad9560 to f294244 Compare October 2, 2014 22:08

btford force-pushed the master branch from 9011a65 to 46db47b Compare October 6, 2014 22:54

jeffbcross force-pushed the master branch 2 times, most recently from abdaab7 to 30996f8 Compare October 8, 2014 19:46

btford modified the milestones: 1.3.0-rc.5, 1.3.0-rc.6 Oct 8, 2014

btford removed this from the 1.3.0-rc.5 milestone Oct 8, 2014

jeffbcross force-pushed the master branch 2 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:37

IgorMinar added the post-1.3.0 label Oct 13, 2014

IgorMinar modified the milestones: 1.3.0-rc.6, 1.3.0 Oct 13, 2014

tbosch modified the milestones: 1.3.x, 1.3.1, Backlog Oct 15, 2014

petebacondarwin force-pushed the master branch from 4dd5a20 to 998c61c Compare October 19, 2014 10:57

caitp closed this Aug 6, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix($location): return '/' for root path in hashbang mode #5712

fix($location): return '/' for root path in hashbang mode #5712

caitp commented Jan 9, 2014

IgorMinar commented Jan 10, 2014

caitp commented Jan 10, 2014

gsklee commented Jan 11, 2014

caitp commented Jan 11, 2014

caitp commented Feb 21, 2014

fix($location): return '/' for root path in hashbang mode #5712

fix($location): return '/' for root path in hashbang mode #5712

Conversation

caitp commented Jan 9, 2014

IgorMinar commented Jan 10, 2014

caitp commented Jan 10, 2014

gsklee commented Jan 11, 2014

caitp commented Jan 11, 2014

caitp commented Feb 21, 2014