Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add the PATCH shortcut back to $http #5823

Closed
langdonx opened this issue Jan 15, 2014 · 4 comments
Closed

Add the PATCH shortcut back to $http #5823

langdonx opened this issue Jan 15, 2014 · 4 comments
Labels
component: $http frequency: moderate needs: public api PRs plz! type: feature
Milestone
1.3.x - superlumi...

Comments

@langdonx
Copy link

Can we add the PATCH shortcut back to $http like so:

createShortMethodsWithData('patch', 'post', 'put');

I'm not entirely sure why it was removed in the first place... that was the only reference I could find about it. I know IE8 support for PATCH is shakey, so maybe this can be a 1.3 thing?
@caitp
Copy link
Contributor

caitp commented Jan 15, 2014

From the commit message,

  • there are too many unknowns about PATCH, so I'm dropping its support until we know that this is actually useful

So we can discuss it in a week or 2 and see if it needs a short-hand method again. In the mean time, there is still "support" for patch ($http({ method: "PATCH", ... })), so be careful not to mislead people about the library ;)

@langdonx
Copy link
Author

Thanks, I couldn't find the commit message (found the gitelephant link through Google and didn't know how to find it on Github). I modified the issue title and body so as to not be misleading. Cheers!

@IgorMinar
Copy link
Contributor

I added this issue to 1.3.x milestone

@cironunes cironunes mentioned this issue Jan 20, 2014
Closed
dagingaa pushed a commit to dagingaa/angular.js that referenced this issue Jan 31, 2014
fix($http): add support for PATCH short method
e47a35e 
Commit 46691c2 removed the short method
for PATCH from $http because there were too many unknows. However, angular#5823
schedules PATCH to be re-added for the 1.3.x milestone.

This change adds the short method for PATCH back to the $http library,
including tests.

Closes angular#5823
@dagingaa dagingaa mentioned this issue Jan 31, 2014
Closed
@Narretz
Copy link
Contributor

Narretz commented Jul 11, 2014

PATCH is baaaaaack since 1.3.0-beta.14

@Narretz Narretz closed this as completed Jul 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: $http frequency: moderate needs: public api PRs plz! type: feature
Projects
None yet
Milestone
1.3.x - superluminal-nudge
4 participants
@IgorMinar @langdonx @Narretz @caitp