-
Notifications
You must be signed in to change notification settings - Fork 27.5k
fix(doc-gen): Run Gulp on Windows too #6346
Conversation
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
Using node_module/.bin/gulp will enable to gulp command to run both on Windows and Linux. In its current form, opening a Javascript file on Windows will not run the doc generation.
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
Thanks @panarasi this looks super useful. |
+1 |
Requires to correctly resolve path on Windows
@sjbarker Made the change. |
@panarasi awesome! Unfortunately, I can only point that question to @mary-poppins. I would double-check and make sure that the checklist provided in the comment above has been completed and that you are sticking to the contributor guidelines. For example, you will want to roll the fix you made into a single commit and follow the commit format. This will ensure that all proper information is included in the release notes. |
bravo |
@petebacondarwin can you look at this? |
On it. |
Using node_module/.bin/gulp will enable to gulp command to run both on Windows and Linux. In its current form, the default action of executing a Javascript file on Windows does not use node. Requires quotes around the command to correctly resolve path on Windows Closes #6346
Using node_module/.bin/gulp will enable to gulp command to run
both on Windows and Linux. In its current form, opening a Javascript
file on Windows will not run the doc generation.