Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Filter 'filter' bugs when values are null #6444

Closed
alexandernst opened this issue Feb 25, 2014 · 4 comments
Closed

Filter 'filter' bugs when values are null #6444

alexandernst opened this issue Feb 25, 2014 · 4 comments

Comments

@alexandernst
Copy link

As described in here: #1780

@pkozlowski-opensource
Copy link
Member

@alexandernst what version of AngularJS did you try? It seems to be OK with the latest released (1.2.13):
http://plnkr.co/edit/NWlHtdGoyDx91CAIJufL?p=preview

@alexandernst
Copy link
Author

@pkozlowski-opensource I'm using 1.2.13: http://plnkr.co/edit/UzUbnECIBqJ9BOLprnw6?p=preview

Anyways, I just realised that maybe I'm wrong. Take a look at lines 20 and 22. That is a comparator function that should be called (and it is called) and that returns true always. Should that make it return all the objects, or the {desc: ''} gets higher priority?

@davidjnelson davidjnelson self-assigned this Feb 26, 2014
@davidjnelson davidjnelson added this to the Purgatory milestone Feb 26, 2014
@davidjnelson
Copy link
Contributor

Thanks @alexandernst for bringing this up. I'm going to reopen #1780 as there are a number of people there who think it's an issue. Thanks @pkozlowski-opensource for reproing with 1.2.13.

@davidjnelson davidjnelson removed their assignment Feb 26, 2014
@willyguevara
Copy link

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants