This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngTouch): add optional ngSwipeDisableMouse attribute to ngSwipe #6627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
…directives to ignore mouse events
|
was this ever added to angular? I need this really bad. I am about to yank ngtouch out of my project because I cannot disable the mouse drag. |
|
@ryanmc2033 I hope this will be answered soon! :)) |
tbosch
pushed a commit
to tbosch/angular.js
that referenced
this pull request
May 14, 2014
…pe` directives to ignore mouse events. This attribute is useful for text that should still be selectable by the mouse and not trigger the swipe action. This also adds an optional third argument to `$swipe.bind` to define the pointer types that should be listened to. Closes angular#6627 Fixes angular#6626
tbosch
pushed a commit
to tbosch/angular.js
that referenced
this pull request
May 14, 2014
…pe` directives to ignore mouse events. This attribute is useful for text that should still be selectable by the mouse and not trigger the swipe action. This also adds an optional third argument to `$swipe.bind` to define the pointer types that should be listened to. Closes angular#6627 Fixes angular#6626
tbosch
pushed a commit
to tbosch/angular.js
that referenced
this pull request
May 14, 2014
…pe` directives to ignore mouse events. This attribute is useful for text that should still be selectable by the mouse and not trigger the swipe action. This also adds an optional third argument to `$swipe.bind` to define the pointer types that should be listened to. Closes angular#6627 Fixes angular#6626
|
Hi, |
|
👍 thx @tbosch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: feature
How to reproduce:
Component(s): ngTouch
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Other Comments:
add optional ngSwipeDisableMouse attribute to ngSwipe directives to ignore mouse events
This is a proposal for #6626 opened by @Nesquick
Let's discuss this.
If it's okay - we should also extend the docs.