Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

jqLite off/unbind leaking event handlers #6685

Closed
g00fy- opened this issue Mar 14, 2014 · 4 comments
Closed

jqLite off/unbind leaking event handlers #6685

g00fy- opened this issue Mar 14, 2014 · 4 comments

Comments

@g00fy-
Copy link

g00fy- commented Mar 14, 2014

plunkr showing native removeEventListener (no leaks) vs jqLite.unbind:
http://plnkr.co/edit/VPfdAMITaqAWNGIZ1eQL?p=preview
in the provided example jqLite.unbind does not remove event listeners.
Note: elements are pushed to window.elements on purpose to simulate more advanced use cases

@thebigredgeek
Copy link
Contributor

I must be missing something. How exactly does this demo show your claim?

@g00fy-
Copy link
Author

g00fy- commented Mar 15, 2014

@thebigredgeek

leaking (leaves event handlers):
leaking

native (removes event handlers):
native

see the event listeners graph. I am suprised that even native doesn't drop to 4 handlers - on other machine the native version drops to 4 (0) event handlers

@SekibOmazic
Copy link
Contributor

#5270

@lefos987
Copy link
Contributor

Thank you for reporting this but as you can see from #5270 this not an actual issue.
Closing it but if you still face issues let us know

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants