This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($parse): mark constant unary minus expressions as constant #6932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Parser.ZERO a constant expression function, so that unary minus expressions that use it may be marked constant.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
LGTM |
|
LGTM |
caitp
pushed a commit
that referenced
this pull request
Apr 2, 2014
Previously, constant numbers with a unary minus sign were not treated as constants. This fix corrects this behaviour, and may provide a small performance boost for certain applications, due to constant watches being automatically unregistered after their first listener call. Closes #6932
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: bug
How to reproduce: Parse an expression like
-42. Check itsconstantflag. Expected:true. Actual:false.Component(s): $parse
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Expressions that use the unary
-operator are currently never marked as constants.Make
Parser.ZEROa constant expression function, so that unary minusexpressions that use it may be marked constant.
Other Comments: