This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): set $isolateScope correctly for sync template directives #6942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
bump... this is a really small fix for something that really annoys me :) |
|
lgtm |
all isolated scope directives that do not have 'templateUrl' where marked as $isolateScopeNoTemplate even if they did have a 'template' attribute. this caused jqLite#scope() to return a different value for child elements in the directive template just because the template loaded synchronously via 'template' and not 'templateUrl'.
petebacondarwin
pushed a commit
that referenced
this pull request
May 9, 2014
All isolated scope directives that do not have `templateUrl` were marked as `$isolateScopeNoTemplate` even if they did have a `template` attribute. This caused `jqLite#scope()` to return the wrong value for child elements within the directive's template. Closes #6942
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: bug
How to reproduce: http://plnkr.co/edit/nxtZGWarSPKHbtuBSiST?p=preview
The directive with 'templateUrl' is marked correctly as $isolateScope, while the directive with 'template' is marked as $isolateScopeNoTemplate and causes jqLite#scope() to return the incorrect scope for children elements
Component(s): $compile
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
all isolated scope directives that do not have 'templateUrl' where marked as $isolateScopeNoTemplate even if they did have a 'template' attribute. this caused jqLite#scope() to return a different value for child elements in the directive template just because the template loaded synchronously via 'template' and not 'templateUrl'.
Other Comments: