This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(addStyle): reference window.angular instead of just angular #7176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e insertion of inline css Reference window.angular instead of just angular because when running angular under an environment where the top-level scope is not the window (nodejs for example), we have to specifically reference window.angular.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
SGTM. Waiting for Travis to get green... |
|
@tbosch Travis is green now. |
petebacondarwin
pushed a commit
that referenced
this pull request
Apr 28, 2014
…ot a global The build includes a little script to angular.js, which adds some CSS styles to the page to support things like ngCloak. This script checks that angular is not in CSP mode, but before this fix assumed that angular would be in the global scope. This commit, references `window.angular` instead of just `angular` because when running angular in an environment where the top-level scope is not the window (nodejs for example), we angular is actually a property of `window`. Closes #7176
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference window.angular instead of just angular because when running angular under an environment
where the top-level scope is not the window (nodejs for example), we have to specifically
reference window.angular.
The main reason for this fix is making running angular under nodejs easier.
Some use cases for this:
Signed CLA as Tom Yam