This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngModel): do not dirty the input if nothing was changed #7495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I'm not sure that this is the correct approach to handle this. @petebacondarwin - would appreciate your opinion on this. |
This caused the input to become dirty every time `$commitViewValue` was called, even if no update to the view value was made. For example, `updateOn` triggers and form submit may call `$commitViewValue` without updating the view value. Closes #7457
|
LGTM |
|
Can't think of a better approach |
|
👍 |
|
lgtm |
RichardLitt
pushed a commit
to RichardLitt/angular.js
that referenced
this pull request
May 24, 2014
…as changed Calling `$commitViewValue` was was dirtying the input, even if no update to the view value was made. For example, `updateOn` triggers and form submit may call `$commitViewValue` even if the the view value had not changed. Closes angular#7457 Closes angular#7495
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused the input to become dirty every time
$commitViewValuewas called, even if no update to the view value was made. For example,updateOntriggers and form submit may call$commitViewValuewithout updating the view value.Closes #7457