This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
perf($interpolate): optimize value stringification #7501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously we stringified numbers via toJson which was expensive, I optimized the code so that toJson is invoked only if really necessary
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
with this tweak, I was able to improve performance of interpolation for templates that use lots of bindings to numbers by 50%. |
|
LGTM |
IgorMinar
added a commit
that referenced
this pull request
May 19, 2014
previously we stringified numbers via toJson which was expensive, I optimized the code so that toJson is invoked only if really necessary Closes #7501
RichardLitt
pushed a commit
to RichardLitt/angular.js
that referenced
this pull request
May 24, 2014
previously we stringified numbers via toJson which was expensive, I optimized the code so that toJson is invoked only if really necessary Closes angular#7501
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we stringified numbers via toJson which was expensive, I optimized the code so that toJson is
invoked only if really necessary