fix(ngAnimate): fix property name that is used to calculate cache key

[4vanger]

Request Type: bug

How to reproduce: I met this issue in an huge screen so I cannot provide a use case.

Component(s): ngAnimate

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

Problem occured when there was 2 ng-hide/ng-show on a page - one had animation assigned and other doesn't. If second item (without animation) is shown/hidden first - then due to this but it get incorrect cache key assigned and it was the same for second animation - so second animation was not animated because it used wrong cacheKey to extract cached timings for non-animated element.

Other Comments:

[mary-poppins]

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

• Uses the issue template (#7566)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[mary-poppins]

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

[4vanger]

I've subscribed CLA 2 days ago but PR still not updated - can you check it please?

[mary-poppins]

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

[caitp]

@4vanger could you please write a test case that fails without this change and add it to test/ngAnimate/animateSpec.js ? thanks!

@matsko this looks correct (based on https://github.com/angular/angular.js/blob/master/src/ngAnimate/animate.js#L1346) --- can you verify and merge this after there is a test case added?

[matsko]

@4vanger can you post your example to Plunkr so I can put together a test for this?

[caitp]

The issue seems to be that you don't get "ng-animate ng-hide-add" classes added (in the case of ng-show/hide) --- small example at http://plnkr.co/edit/96ftv9oLnMTxkllQXlre?p=preview

It doesn't really break the animation, so still waiting on a reproduction about that. But yeah you probably want those classes to be set

[4vanger]

Huh, it took a while to make it simple: http://plnkr.co/edit/4V8UO2wLVFFymAxh0liw
comment line 28 to make this example behave correctly

[matsko]

@caitp can you review this? matsko@c016703

[caitp]

@matsko LGTM

[matsko]

MERGED

[caitp]

🎊

[matsko]

@4vanger thanks for finding the bug and for fixing this! @caitp thanks for looking into the issue and for the review.

[matsko]

PS. This issue does not exist at all on the 1.2.x branch. So no need to merge there.