This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($animate): allow directives to cancel animation events #7722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
como estas matias |
matsko
added a commit
to matsko/angular.js
that referenced
this pull request
Jun 6, 2014
|
does the delegate really need to return noop for everything? it looks like ngAnimate will use noop if the value is falsy anyways |
|
Yes, but when ngAnimate is not included then the core $animate service should still return a function. |
|
|
||
| function track(type) { | ||
| return function(element, add, remove, done) { | ||
| done = done || remove || add; |
There was a problem hiding this comment.
what's the purpose of this?
There was a problem hiding this comment.
setClass = 4 params (done is the last one)
addClass / removeClass = 3 params (done is the one)
enter / leave / move = 2 params (done is the last one)
So it's basically finding the done function.
matsko
added a commit
to matsko/angular.js
that referenced
this pull request
Jul 1, 2014
|
lgtm |
|
MERGED as ca75279 |
matsko
added a commit
that referenced
this pull request
Jul 1, 2014
ckknight
pushed a commit
to ckknight/angular.js
that referenced
this pull request
Jul 16, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.