This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf(isArray): use native Array.isArray #7735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return toString.call(value) === '[object Array]'; | ||
| }; | ||
| } | ||
| return function(value) { |
There was a problem hiding this comment.
return Array.isArray; --- this is a static and doesn't depend on being attached to the Array constructor
|
LGTM with comments addressed |
|
@caitp thanks for your comments, done! |
|
For a minor edit (just to make sure toString actually exists) http://jsperf.com/isarray-performance/2 I get pretty good results (with |
|
lgtm |
|
👍 |
|
merg'd~ |
|
👯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: perf
How to reproduce:
Component(s): misc core
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Other Comments:
see benchmark: http://jsperf.com/isarray-performance