fix($rootScope): remove support for a watch listener to be a string #8190
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
This is fine to me --- I was confused for a moment because I read this description as saying "EXPRESSIONS CAN NO LONGER BE WATCHED". +1 for this CL |
|
I was also confused by this at first as well--then I read the changes to the tests, and it made sense. |
|
I was confused there for a moment, too. Can you please add the complimentary before / after part to the BREAKING CHANGE notice? |
BREAKING CHANGE:
Previously, it was possible for an action passed to $watch
to be a string, interpreted as an angular expresison. This is no longer supported.
The action now has to be a function.
Passing an action to $watch is still optional.
Before:
```js
$scope.$watch('state', ' name="" ');
```
After:
```js
$scope.$watch('state', function () {
$scope.name = "";
});
```
|
Igor proposed renaming Also added a before / after part to the commit message |
BREAKING CHANGE:
Previously, it was possible for an action passed to $watch
to be a string, interpreted as an angular expresison. This is no longer supported.
The action now has to be a function.
Passing an action to $watch is still optional.
Before:
```js
$scope.$watch('state', ' name="" ');
```
After:
```js
$scope.$watch('state', function () {
$scope.name = "";
});
```
Closes angular#8190
BREAKING CHANGE:
Previously, it was possible for a listener passed to $watch
to be a string, interpreted as an angular expresison. This is no longer supported.
The listener now has to be a function.
Passing a listener to $watch is still optional.