-
Notifications
You must be signed in to change notification settings - Fork 27.4k
feat(*): log warning message for deprecated APIs #8195
Comments
The changelog entry where this is announced actually says it'll be removed in the next major release, which is incorrect if it'll be removed in 1.x Also, the docs don't mention what behavior will be the default when this happens. Obvious if you the core, but not so much for other devs. Might as well tackle these while we're at it |
it's not clear that there's any point in logging a warning here --- why not do this from the directive hint project instead? I mean, telling people that what they're doing is a bad idea in the web console might not be super helpful / informative, and potentially gets spammy. Plus, I think it's been established that at no point will this actually be "removed" (except for 2.0, which doesn't count), so maybe logging this doesn't do that much? If it's possible to let the hint project warn about this, that's what I'd go for --- otherwise maybe make it possible for that sort of thing. |
This feature has been added to http://github.com/angular/angular-hint-directives in f1fa66cc79ff00fb65919b438951cc3226e43f6e |
Landed in –> https://github.com/angular/angular-hint-directives/commit/f1fa66cc79ff00fb65919b438951cc3226e43f6e I'm fine with this not being in core. |
@btford It's still not clear (to me) if replace is going to be removed in 2.0, 1.x or even 1.3.x. I think it's worth clarifying. The changelog says "next major", so say the docs. Next major and 1.3.x (as you said here) is a pretty big difference. |
I never said we would remove it in I think it's reasonable for us to (at some point in an appropriate breaking release) remove it from Angular 2 is a total rewrite. It simply won't have this feature. |
Ah sorry, you're right, I mixed up the lines about deprecating and removing |
We are planning to deprecate the
replace
option in1.3.x
. "Deprecate" here means that we are not going to spend time implementing complex fixes related to this feature, and we would like to remove it in some future breaking1.x
release.Right now the only place this is mentioned is in the docs.
In the same vein in
minErr
, it would be nice to have warnings that get stripped out at run-time.The text was updated successfully, but these errors were encountered: