Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(*): log warning message for deprecated APIs #8195

Closed
btford opened this issue Jul 14, 2014 · 7 comments
Closed

feat(*): log warning message for deprecated APIs #8195

btford opened this issue Jul 14, 2014 · 7 comments

Comments

@btford
Copy link
Contributor

btford commented Jul 14, 2014

We are planning to deprecate the replace option in 1.3.x. "Deprecate" here means that we are not going to spend time implementing complex fixes related to this feature, and we would like to remove it in some future breaking 1.x release.

Right now the only place this is mentioned is in the docs.

In the same vein in minErr, it would be nice to have warnings that get stripped out at run-time.

@btford btford added this to the 1.3.0-beta.16 milestone Jul 14, 2014
@btford btford self-assigned this Jul 14, 2014
@Narretz
Copy link
Contributor

Narretz commented Jul 14, 2014

The changelog entry where this is announced actually says it'll be removed in the next major release, which is incorrect if it'll be removed in 1.x Also, the docs don't mention what behavior will be the default when this happens. Obvious if you the core, but not so much for other devs. Might as well tackle these while we're at it

@caitp
Copy link
Contributor

caitp commented Jul 14, 2014

it's not clear that there's any point in logging a warning here --- why not do this from the directive hint project instead?

I mean, telling people that what they're doing is a bad idea in the web console might not be super helpful / informative, and potentially gets spammy. Plus, I think it's been established that at no point will this actually be "removed" (except for 2.0, which doesn't count), so maybe logging this doesn't do that much?

If it's possible to let the hint project warn about this, that's what I'd go for --- otherwise maybe make it possible for that sort of thing.

@caguillen214
Copy link

This feature has been added to http://github.com/angular/angular-hint-directives in f1fa66cc79ff00fb65919b438951cc3226e43f6e

@btford
Copy link
Contributor Author

btford commented Jul 16, 2014

@btford btford closed this as completed Jul 16, 2014
@Narretz
Copy link
Contributor

Narretz commented Jul 16, 2014

@btford It's still not clear (to me) if replace is going to be removed in 2.0, 1.x or even 1.3.x. I think it's worth clarifying. The changelog says "next major", so say the docs. Next major and 1.3.x (as you said here) is a pretty big difference.

@btford
Copy link
Contributor Author

btford commented Jul 16, 2014

I never said we would remove it in 1.3.x. That simply doesn't make sense. I said it's deprecated starting with 1.3.x – we aren't spending time on fixes for it any more.

I think it's reasonable for us to (at some point in an appropriate breaking release) remove it from 1.x if it would allow us to simplify or refactor code.

Angular 2 is a total rewrite. It simply won't have this feature.

@Narretz
Copy link
Contributor

Narretz commented Jul 17, 2014

Ah sorry, you're right, I mixed up the lines about deprecating and removing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants