Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($compile): updating the jQuery .context when it is replaced #8253

Closed
wants to merge 1 commit into from

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Jul 18, 2014

This allows replaced DOM nodes to be GCed when using jQuery. The issue is pretty minor and the jQuery .context might be removed in the future (see https://api.jquery.com/context/), but the fix is pretty simple.

Fixes #7900

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8253)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@jbedard jbedard added cla: yes and removed cla: no labels Jul 18, 2014
@Narretz Narretz added this to the Backlog milestone Jul 18, 2014
@mgol
Copy link
Member

mgol commented Aug 7, 2014

I'll look into it.

@mgol mgol modified the milestones: Backlog, 1.3.0-beta.18 Aug 7, 2014
@IgorMinar IgorMinar closed this in f02f7d9 Aug 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace directive $element still references replaced DOM element
6 participants