Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(jqLite): fix regression where mutating the dom tree on a event breaks jqLite.remove #8359

Closed

Conversation

rodyhaddad
Copy link
Contributor

012ab1f introduced a regression where if a user's $destroy event modified the descendant DOM tree, jqLite.remove would break.
This is because it uses getElementsByTagName and caches the length of the returned live NodeList

cc @ggoodman

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8359)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@jeffbcross jeffbcross self-assigned this Jul 28, 2014
@jeffbcross
Copy link
Contributor

LGTM, merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants