Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($sanitize): dont not remove tab index property #8371

Closed
wants to merge 3 commits into from
Closed

fix($sanitize): dont not remove tab index property #8371

wants to merge 3 commits into from

Conversation

chirag04
Copy link
Contributor

fixes #5853

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8371)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@chirag04 chirag04 added cla: yes and removed cla: no labels Jul 28, 2014
@Narretz
Copy link
Contributor

Narretz commented Jul 28, 2014

Hi, thanks for the PR; while it's a very simple change it's better to put your changes on a separate branch, and rebase that branch on master to stay up to date. When you merge the master, you create these merge commits and add unrelated commits which makes it harder to review.

@caitp
Copy link
Contributor

caitp commented Jul 28, 2014

I wouldn't worry about it, it's trivial to just pick the commit we want from here when checking it in.

Should include a simple test case, as well --- no need to test anything functional, just make sure that the attribute doesn't get discarded

@chirag04
Copy link
Contributor Author

@caitp @Narretz Should i create a new branch with a testcase for it?

@caitp
Copy link
Contributor

caitp commented Jul 28, 2014

@chirag04 don't worry about creating a new branch, you can simply amend this last commit with a test case, when we land this we'll only take the last commit since the first one has already been fixed seperately

@caitp
Copy link
Contributor

caitp commented Jul 28, 2014

In the future though, you should put all your fixes and features into branches, so that you don't accidentally overwrite them =)

@lgalfaso
Copy link
Contributor

landed as 799353c

netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$sanitize removes the tabindex property
7 participants