-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix($sanitize): dont not remove tab index property #8371
Conversation
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Hi, thanks for the PR; while it's a very simple change it's better to put your changes on a separate branch, and rebase that branch on master to stay up to date. When you merge the master, you create these merge commits and add unrelated commits which makes it harder to review. |
I wouldn't worry about it, it's trivial to just pick the commit we want from here when checking it in. Should include a simple test case, as well --- no need to test anything functional, just make sure that the attribute doesn't get discarded |
@chirag04 don't worry about creating a new branch, you can simply amend this last commit with a test case, when we land this we'll only take the last commit since the first one has already been fixed seperately |
In the future though, you should put all your fixes and features into branches, so that you don't accidentally overwrite them =) |
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
landed as 799353c |
fixes #5853