This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf(jqLite): only take str.split() path when needed #8648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bda673f changed code to only use `str.split()` when necessary, but the result was that `str.split()` would always be taken unless ' ' was the first character in the string, negating the effectiveness of the perf fix.
|
This looks correct. The weird thing is that even the broken optimization made huge perf difference. |
|
interesting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bda673f changed code to only use
str.split()when necessary, but the result was thatstr.split()wouldalways be taken unless ' ' was the first character in the string, negating the
effectiveness of the perf fix.
/cc @IgorMinar --- re bda673f#commitcomment-7417474
Lets check this in fast, since it's such a tiny change