This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): set baseHref in mock browser to /
#8889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the default value for the base tag in the mock browser to `/`, as we now always require a base tag to be present for html5 mode. Fixes angular#8866.
|
@jeffbcross Could you review this? |
|
@tbosch sure |
|
LGTM if Travis is happy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default value for the base tag in the mock browser to
/,as we now always require a base tag to be present for html5 mode.
Fixes #8866.