This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): support removing classes from SVG elements when using jQuery #8893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… jQuery Without this CL, ngShowHide will not work without the use of monkeypatched fixes for jQuery such as https://github.com/kbwood/svg 's jquery-svgdom.js script. Closes angular#8872
|
LGTM please merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this CL, ngShowHide will not work without the use of monkeypatched
fixes for jQuery such as https://github.com/kbwood/svg 's jquery-svgdom.js
script.
/CC @matsko / @IgorMinar --- as noted above, people can make this work by including third party
scripts, but I thought since this is technically a regression I would write a patch anyways and
see what people think.
So, the main thing is that this is not reusing the existing jqLiteHasClass method, because jqLite
is not exported unless jQuery is not found. We could fix this to support code reuse, if we want
to fix this at all.
There is one other use of
.hasClass()in ngAnimate that I can see, so it's likely that anotherSVG scenario is broken in jQuery by default, but I haven't investigated to see what that other
scenario is.
Balls in your court, do you think we should fix it or just defer the work to third party code
like jquery-svgdom
Closes #8872