This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngModelOptions): do not trigger digest during debounce #8911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petebacondarwin Could you LGTM this? |
|
Wasn't there already a PR by @shahata for this? |
|
Yes, this one is just a little modification of it before I merge it into master:
|
This change means that anyone watching `$viewValue` will no longer see the update immediately for debounced updates Closes angular#8814
tbosch
force-pushed
the
debouncedigest2
branch
from
a5601d1 to
b38d17c
Compare
|
From my phone it lgtm |
tbosch
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for merging #8850