This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngResource): make badcfg error message more helpful #9010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message should help identify the problem. To do so, more details need to be provided. Closes angular#9005
|
@petebacondarwin can you review? It's pretty tiny. I think it would actually be better if we exposed the requested URL in the error, but unfortunately that's a bit harder to test reliably |
caitp
added
component: ngResource
type: bug
severity: inconvenient
and removed
type: bug
labels
|
Good stuff. I'll merge |
|
Ah, I was just running |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message should help identify the problem. To do so, more details
need to be provided.
Closes #9005