This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngModel): don't parse before validating if viewValue is undefined #9260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbosch this should be really quick to review, can you take a quick look? |
|
|
||
| scope.$apply("required = false"); | ||
|
|
||
| expect(inputElm).toBeValid(); |
There was a problem hiding this comment.
this assertion does fail without this change
caitp
changed the title
caitp
changed the title
| var parserValid = isUndefined(modelValue) ? undefined : true; | ||
|
|
||
| if (parserValid) { | ||
| for(var i = 0; i < ctrl.$parsers.length; i++) { |
There was a problem hiding this comment.
ii = ctrl.$parsers.length ?
There was a problem hiding this comment.
There are no tests, but it's technically possible for the parsers array to grow while a parser is running, so changing that could be a breaking change.
We can do it but it might not be a good commit to do it in
|
LGTM |
|
thanks, that is one less bug on the checklist \o/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents unintentionally reporting an undefined view value as a parse error...
Closes #9106