This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor(ngView): remove previousElement bookkeeping #9355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's unnecessary and inconsistent (because finishing animations reset we see situations where not previousElement is not always removed and more than one leave animation is going on at the same time). Closes angular#7606 Closes angular#9355
IgorMinar
force-pushed
the
ngview-previouselement
branch
from
da3fb66 to
e487292
Compare
|
we should keep the cleanup, but do it similarly as we do in ngSwitch: angular.js/src/ng/directive/ngSwitch.js Lines 153 to 155 in b1ee538 |
Closed
IgorMinar
added a commit
to IgorMinar/angular.js
that referenced
this pull request
Oct 1, 2014
…ion occurs at a time the tracking depended on a local flag variable, which was susceptible to corruption due to race conditions. Closes angular#9355 Closes angular#7606
|
closed in favor of #9374 9374 |
IgorMinar
added a commit
to IgorMinar/angular.js
that referenced
this pull request
Oct 1, 2014
…ion occurs at a time the tracking depended on a local flag variable, which was susceptible to corruption due to race conditions. Closes angular#9355 Closes angular#7606 Closes angular#9374
IgorMinar
added a commit
to IgorMinar/angular.js
that referenced
this pull request
Oct 1, 2014
…ion occurs at a time the tracking depended on a local flag variable, which was susceptible to corruption due to race conditions. using promises ensures that the previousLeaveAnimation is nulled out only if it hasn't been canceled yet. Closes angular#9355 Closes angular#7606 Closes angular#9374
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's unnecessary and inconsistent (because finishing animations reset we see situations
where not previousElement is not always removed and more than one leave animation is going on at the same time).
Closes #7606