This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(input): correctly handle invalid model values for `input[date/time/…... #9375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffbcross Could you review this? |
|
@tbosch sure |
|
LGTM, other than two nit-picks left on the commit |
tbosch
force-pushed
the
fix/invalidmodel
branch
from
54904bd to
ce7980f
Compare
tbosch
added a commit
to tbosch/angular.js
that referenced
this pull request
Oct 1, 2014
…e/…]` Similar to `input[number]` Angular will throw if the model value for a `input[date]` is not a `Date` object. For `Invalid Date`s (dates whose `getTime()` is `NaN`) `input[date]` will render an empty string. Closes angular#8949 Closes angular#9375
tbosch
force-pushed
the
fix/invalidmodel
branch
from
ce7980f to
533a312
Compare
tbosch
added a commit
to tbosch/angular.js
that referenced
this pull request
Oct 1, 2014
…e/…]` Similar to `input[number]` Angular will throw if the model value for a `input[date]` is not a `Date` object. For `Invalid Date`s (dates whose `getTime()` is `NaN`) `input[date]` will render an empty string. Closes angular#8949 Closes angular#9375
|
@jeffbcross Could you double check the error message (as a native speaker) |
|
@tbosch Gladly, I will put on my native speaker hat. |
| @fullName Model is not a date object | ||
| @description | ||
|
|
||
| All date related inputs like `<input type="date">` require the model to be a `Date` object. |
There was a problem hiding this comment.
Should have hyphen, "date-related"
|
One native speaker comment but otherwise LGTM. |
…e/…]` Similar to `input[number]` Angular will throw if the model value for a `input[date]` is not a `Date` object. For `Invalid Date`s (dates whose `getTime()` is `NaN`) `input[date]` will render an empty string. Closes angular#8949 Closes angular#9375
tbosch
force-pushed
the
fix/invalidmodel
branch
from
533a312 to
a0bfdd0
Compare
|
Ok, waiting for travis, then will merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...]`
Similar to
input[number]Angular will throw if the model valuefor a
input[date]is not aDateobject.For
Invalid Dates (dates who’sgetTime()isNaN)input[date]will render an empty string.
Closes #8949