Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

DEEP-LINKING ON HTL5MODE BROKEN ON IE9 FOREVER #9380

Closed
acostaf opened this issue Oct 2, 2014 · 3 comments
Closed

DEEP-LINKING ON HTL5MODE BROKEN ON IE9 FOREVER #9380

acostaf opened this issue Oct 2, 2014 · 3 comments

Comments

@acostaf
Copy link

acostaf commented Oct 2, 2014

Sorry @IgorMinar and @mhevery I am opening a new Issue about the same broken issue that never get fixed.

I do understand the Ie9 is old and annoying but when you work in a big bank/ Insurance / Multinational Chrome is blocked by default, making IE9/10 the default browser on you organization, we are fighting for this to change but when your organisation got 250K pc running on the same browser change happen really slowly.

I was posting my pain on #9235 but I think I needed to push that faster

@btford @jeffbcross @chrisirhc this issue was reported more than a year ago by @geoffliddiard on #1864 also on the same issue for @bstruthers was reported that still was broken but you choose to close it rather than fix it and we still are having those issue, also @IgorMinar commented about similar issue two years ago.

@acostaf
Copy link
Author

acostaf commented Oct 2, 2014

The main issue happens when you are in IE9 and the hash is added to the url but the new URL from deep linking does not contains the hash ( on if (lastBrowserUrl == self.url()) return;)

angular.js File from line 4678

    function fireUrlChange() {
      newLocation = null;
      if (lastBrowserUrl == self.url()) return;

      lastBrowserUrl = self.url();
      forEach(urlChangeListeners, function(listener) {
        listener(self.url());
      });
    }  

@IgorMinar
Copy link
Contributor

closing as duplicate of #9235

if you want to accelerate the fix submit a clean test or even better a fix. creating duplicate issues only slow the development down.

@acostaf
Copy link
Author

acostaf commented Oct 2, 2014

Hi @IgorMinar you are already about the dupe, sorry to open this again but I first reported this issue back in May and after that many other people reported it including you, please see the repro step on #9235 and my comment about fireurlchanges that are the main reason why this is happening, I hope you may fix it since I got this nasty issue in production that Chris the whole browser because angular it is using all memory and maxim out the country because the loops.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants