This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($anchorScroll): don't scroll to top when initializing and location h... #9393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n hash is empty Closes angular#8848 Closes angular#9393
IgorMinar
force-pushed
the
anchorscroll-init-scroll
branch
from
db7c6d7 to
f14588f
Compare
|
@tbosch please review |
|
LGTM |
|
Restarting Travis... |
|
I love the test helpers in this spec file. Someone should blog or present about how to write DRY and non-brittle tests that are easy to understand. |
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
abdaab7 to
30996f8
Compare
bullgare
pushed a commit
to bullgare/angular.js
that referenced
this pull request
Oct 9, 2014
…n hash is empty Closes angular#8848 Closes angular#9393
|
Will be this applied into 1.2.x? |
|
@shigi - No, 1.2.x is only receiving security and major regression fixes now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ash is empty
Closes #8848