feat($routeProvider): allow setting caseInsensitiveMatch on the provider #9873
Conversation
| @@ -141,10 +141,13 @@ function $RouteProvider() { | |||
| * Adds a new route definition to the `$route` service. | |||
| */ | |||
| this.when = function(path, route) { | |||
| var routeWithDefaults = angular.extend({ | |||
There was a problem hiding this comment.
this will need to change slightly if #9731 lands, and I think we want to land it
There was a problem hiding this comment.
Yup, but it shouldn't be a big deal. I can rebase / change this one when #9731 lands. I would like to get this one in as I was really surprised that we can't have provider-level definition for case-sensitive routes.
There was a problem hiding this comment.
#9731 has landed, should rebase
pkozlowski-opensource
force-pushed
the
issue6477
branch
from
4bdf4db to
ff13227
Compare
|
@caitp it was rebased on master after #9731landed. Ready for the review / merging. |
|
thanks, looking |
| @@ -146,6 +146,9 @@ function $RouteProvider() { | |||
| if (angular.isUndefined(routeCopy.reloadOnSearch)) { | |||
| routeCopy.reloadOnSearch = true; | |||
| } | |||
| if (angular.isUndefined(routeCopy.caseInsensitiveMatch)) { | |||
There was a problem hiding this comment.
I wonder if we should use if (!'prop' in routeCopy) instead, since that's really what we're testing. Either way, looks fine to me
|
@caitp thnx for the review. I guess based on your comments we could merge it but then we need to figure safe way of landing those types of things in 1.3.x / 1.4. Which goes back to the discussion we had yesterday. I guess this PR is a perfect example of little / low risk new features for which we need to figure out good strategy. |
|
well it's not really changing existing behaviour, it's adding a new behaviour --- so it should be pretty safe. |
|
@pkozlowski-opensource this looks good to me, merge at will |
Fixes #6477