This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf(orderBy): copy array with slice instead of for loop #9942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var arrayCopy = []; | ||
| for (var i = 0; i < array.length; i++) { arrayCopy.push(array[i]); } | ||
| return arrayCopy.sort(reverseComparator(comparator, reverseOrder)); | ||
| return array.slice().sort(reverseComparator(comparator, reverseOrder)); |
There was a problem hiding this comment.
The problem with this is that array is not necessarlly an Array. it can be an array-like object. This only works in the Array case.
|
Can you make sure that this will work with ArrayLike objects (with a test case) and ping me when it's ready? |
|
I'm afraid it doesn't work with ArrayLike object |
|
Note that a reference to |
|
Sure, I'm going back from vacations tomorrow and I will apply the changes :) |
Use array slice method to copy entire array instead of a for loop http://jsperf.com/new-array-vs-splice-vs-slice/54
kwypchlo
force-pushed
the
perf-orderby-filter
branch
from
1cd391d to
3024501
Compare
|
@caitp I've amended the commit to include what @jimmywarting and @gkalpak were suggesting as a fix for array like objects. It looks fine now and it works as expected. |
|
looks ok to me, will land in a few minutes |
caitp
pushed a commit
to caitp/angular.js
that referenced
this pull request
Nov 14, 2014
Use array slice method to copy entire array instead of a for loop http://jsperf.com/new-array-vs-splice-vs-slice/54 Closes angular#9942
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use array slice method to copy entire array instead of a for loop
http://jsperf.com/new-array-vs-splice-vs-slice/54