Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Migrating from Previous Versions): Add an issue with HTML … #12052

Closed
wants to merge 1 commit into from
Closed

Conversation

iwhp
Copy link

@iwhp iwhp commented Jun 8, 2015

…select tag and numeric values

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@iwhp
Copy link
Author

iwhp commented Jun 8, 2015

I signed it!

From: googlebot [mailto:notifications@github.com]
Sent: Montag, 8. Juni 2015 19:05
To: angular/angular.js
Cc: Harry Pfleger
Subject: Re: [angular.js] docs(guide/Migrating from Previous Versions): Add an issue with HTML … (#12052)

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

[:memo:]Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA datahttps://cla.developers.google.com/clas and verify that your email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/.
  • If you signed the CLA as a corporation, please let us know the company's name.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12052#issuecomment-110073850.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 8, 2015
Narretz added a commit to Narretz/angular.js that referenced this pull request Jun 8, 2015
@Narretz Narretz self-assigned this Jun 8, 2015
@Narretz Narretz closed this in a69251a Jun 8, 2015
@Narretz
Copy link
Contributor

Narretz commented Jun 8, 2015

Thanks for the PR & for bringing this issue to our attention. I committed a little different version that explains possible workarounds. Keep up the good work!

@iwhp
Copy link
Author

iwhp commented Jun 9, 2015

Thankx Narretz. This looks very good. Maybe it is just me, but I could not implement your second suggestion: "or implement a parser on ngModel that converts the option string value to a Number.". Could you please provide a sample. Thankx, Harry

@Narretz
Copy link
Contributor

Narretz commented Jun 9, 2015

You are right, a parser alone doesn't work - you need a formatter, too: http://plnkr.co/edit/JZPay8jgm5AXKGXDCjSb

@iwhp
Copy link
Author

iwhp commented Jun 9, 2015

Great - Thankx!

Narretz added a commit to Narretz/angular.js that referenced this pull request Jun 9, 2015
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants