Skip to content

Commit

Permalink
fix(router): incorrect signature for createUrlTree (#39347)
Browse files Browse the repository at this point in the history
The type of the `navigationExtras` param was accidetally changed to the wrong symbol
in 783a5bd.
These changes revert it to the correct one.

PR Close #39347
  • Loading branch information
crisbeto authored and AndrewKushnir committed Oct 20, 2020
1 parent 3738233 commit 161b278
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion goldens/public-api/router/router.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ export declare class Router {
urlHandlingStrategy: UrlHandlingStrategy;
urlUpdateStrategy: 'deferred' | 'eager';
constructor(rootComponentType: Type<any> | null, urlSerializer: UrlSerializer, rootContexts: ChildrenOutletContexts, location: Location, injector: Injector, loader: NgModuleFactoryLoader, compiler: Compiler, config: Routes);
createUrlTree(commands: any[], navigationExtras?: NavigationExtras): UrlTree;
createUrlTree(commands: any[], navigationExtras?: UrlCreationOptions): UrlTree;
dispose(): void;
getCurrentNavigation(): Navigation | null;
initialNavigation(): void;
Expand Down
2 changes: 1 addition & 1 deletion packages/router/src/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1096,7 +1096,7 @@ export class Router {
* router.createUrlTree(['../../team/44/user/22'], {relativeTo: route});
* ```
*/
createUrlTree(commands: any[], navigationExtras: NavigationExtras = {}): UrlTree {
createUrlTree(commands: any[], navigationExtras: UrlCreationOptions = {}): UrlTree {
const {relativeTo, queryParams, fragment, queryParamsHandling, preserveFragment} =
navigationExtras;
const a = relativeTo || this.routerState.root;
Expand Down

0 comments on commit 161b278

Please sign in to comment.