fix(router): runs guards every time when unsuccessfully navigating to… #13209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
reviewed
Dec 2, 2016
| @@ -387,8 +387,17 @@ export class Router { | |||
| // which does not work properly with zone.js in IE and Safari | |||
| this.locationSubscription = <any>this.location.subscribe(Zone.current.wrap((change: any) => { | |||
| const rawUrlTree = this.urlSerializer.parse(change['url']); | |||
| const lastNavigation = this.navigations.value; | |||
|
|
|||
| // TODO add a comment describing why it has to be like that | |||
vsavkin
added
the
action: review
vicb
reviewed
Dec 2, 2016
| extras: NavigationExtras, | ||
| resolve: any, | ||
| reject: any, | ||
| promise: Promise<boolean> | ||
| imperative: boolean; |
There was a problem hiding this comment.
I also never remember if it should be ,/; in types but here you have ""/,/;, must be wrong
vsavkin
force-pushed
the
router_guard_called_only_once
branch
from
eebaba0 to
2438965
Compare
… the same url over and over again
vicb
added
action: merge
maxime-allex
pushed a commit
to Linkurious/angular
that referenced
this pull request
Dec 6, 2016
… the same url over and over again (angular#13209)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12851