Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): update route snapshot before emit new values #13558

Merged
merged 1 commit into from
Dec 27, 2016

Conversation

DzmitryShylovich
Copy link
Contributor

@DzmitryShylovich DzmitryShylovich commented Dec 18, 2016

Closes #12912

Description:
As you can see on the screenshot http://prntscr.com/dl0c79 we emit new params before we actually update route.snapshot value this is why we see previous snapshot inside a subscription. So it's a timing issue and to fix it we just need to update route.snapshot before emitting any values.

#12912 (comment) 👍

@vicb
Copy link
Contributor

vicb commented Dec 22, 2016

Thanks !

@vicb vicb added area: router action: merge The PR is ready for merge by the caretaker pr_state: LGTM labels Dec 22, 2016
@hansl hansl merged commit 07e0fce into angular:master Dec 27, 2016
@DzmitryShylovich DzmitryShylovich deleted the gh/12912 branch December 27, 2016 23:57
IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Jan 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActivatedRoute.snapshot has old data when route changes
4 participants