fix(router): update route snapshot before emit new values #13558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12912
Description:
As you can see on the screenshot http://prntscr.com/dl0c79 we emit new params before we actually update
route.snapshot
value this is why we see previous snapshot inside a subscription. So it's a timing issue and to fix it we just need to updateroute.snapshot
before emitting any values.#12912 (comment) 👍