-
Notifications
You must be signed in to change notification settings - Fork 25.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): do not override locale provided on bootstrap #13654
Conversation
2940df9
to
a0d4e0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test
4811095
to
fec3ec2
Compare
@vicb There's a problem with writing a test case for it :)
but they are not available for the app. |
Create an e2e test? |
087edc1
to
1929ff1
Compare
8a80ca8
to
6260ed4
Compare
@vicb added a test |
great, thanks ! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #13607