fix(compiler-cli): set source file ranges in node emitter #19348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 6989579 at https://pr19348-6989579.ngbuilds.io/. |
chuckjaz
force-pushed
the
source-map-2
branch
from
6989579 to
2af6c0f
Compare
Enables source mapping from the template to the generated files.
chuckjaz
force-pushed
the
source-map-2
branch
from
2af6c0f to
95f9552
Compare
|
You can preview 2af6c0f at https://pr19348-2af6c0f.ngbuilds.io/. |
|
You can preview 95f9552 at https://pr19348-95f9552.ngbuilds.io/. |
tbosch
approved these changes
Sep 26, 2017
IgorMinar
approved these changes
Sep 26, 2017
IgorMinar
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables source mapping from the template to the generated files.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The source maps produced for generated code does not include template information.
What is the new behavior?
The source maps produced for the code generate for templates maps back to the generated template.
Does this PR introduce a breaking change?