feat(forms): add support for radio buttons #6877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
added
the
action: review
| expect(value['foodFish'].checked).toEqual(false); | ||
| async.done(); | ||
| }); | ||
| })); |
There was a problem hiding this comment.
In addition to this case where you use the "change" event, you should also have a case where one radio button becomes deselected by clicking another with the same name (because the deselection won't have an associated event).
There was a problem hiding this comment.
I added tests covering it
|
LGTM aside from the need for additional test case |
vsavkin
force-pushed
the
fix_input_type_radio
branch
from
c2b964f to
b1ad032
Compare
vsavkin
added
pr_state: LGTM
action: merge
vsavkin
force-pushed
the
fix_input_type_radio
branch
from
b1ad032 to
6983735
Compare
vsavkin
force-pushed
the
fix_input_type_radio
branch
from
6983735 to
c7a6416
Compare
|
Merging PR #6877 on behalf of @btford to branch presubmit-btford-pr-6877. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5133, Fixes #3104