Skip to content

Commit

Permalink
fix(schematic): use oneOf rather than array types in the deploy schem…
Browse files Browse the repository at this point in the history
…atic (#3092)

Use `oneOf` instead of `"type": ["a", "b"]` to fix the `ng deploy` command
  • Loading branch information
kfrancois authored Feb 7, 2022
1 parent b60670c commit 058d624
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/schematics/deploy/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"pattern": "^[^:\\s]+:[^:\\s]+(:[^\\s]+)?$"
},
"ssr": {
"type": ["boolean", "string"],
"oneOf": [{ "type": "boolean" }, { "type": "string" }],
"description": "Should we attempt to deploy the function to Cloud Functions (true or 'cloud-functions') / Cloud Run ('cloud-run') or just Hosting (false)"
},
"prerender": {
Expand All @@ -54,7 +54,7 @@
"description": "The name of the Cloud Function or Cloud Run serviceId to deploy SSR to"
},
"functionsNodeVersion": {
"type": ["number", "string"],
"oneOf": [{ "type": "number" }, { "type": "string" }],
"description": "Version of Node.js to run Cloud Functions / Run on"
},
"region": {
Expand Down Expand Up @@ -82,12 +82,12 @@
"description": "Set a CPU limit in Kubernetes cpu units."
},
"maxConcurrency": {
"type": ["number", "string"],
"oneOf": [{ "type": "number" }, { "type": "string" }],
"pattern": "^(\\d+|default)$",
"description": "Set the maximum number of concurrent requests allowed per container instance. If concurrency is unspecified, any number of concurrent requests are allowed. To unset this field, provide the special value default."
},
"maxInstances": {
"type": ["number", "string"],
"oneOf": [{ "type": "number" }, { "type": "string" }],
"pattern": "^(\\d+|default)$",
"description": "The maximum number of container instances of the Service to run. Use 'default' to unset the limit and use the platform default."
},
Expand All @@ -97,7 +97,7 @@
"description": "Set a memory limit. Ex: 1Gi, 512Mi."
},
"minInstances": {
"type": ["number", "string"],
"oneOf": [{ "type": "number" }, { "type": "string" }],
"pattern": "^(\\d+|default)$",
"description": "The minimum number of container instances of the Service to run or 'default' to remove any minimum."
},
Expand Down

0 comments on commit 058d624

Please sign in to comment.